ASTPP 6 Common Model issue get_dashboard_details()

linux.kernel · July 15, 2023, 6:01pm

iNextrix/ASTPP/blob/V6.0/web_interface/astpp/application/models/common_model.php

<?php
// ##############################################################################
// ASTPP - Open Source VoIP Billing Solution
//
// Copyright (C) 2016 iNextrix Technologies Pvt. Ltd.
// Samir Doshi <samir.doshi@inextrix.com>
// ASTPP Version 3.0 and above
// License https://www.gnu.org/licenses/agpl-3.0.html
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License

This file has been truncated. show original

Please consider removing line #35 as it is causing huge delay for other pages load time by calling get_dashboard_details() function.

Thanks

KNERD · July 15, 2023, 7:39pm

You could discuss the issue here on why you think it is causing a delay then do a pull request

linux.kernel · July 16, 2023, 12:34pm

Ok. Here are my findings

Have noticed massive slowness on loading dashboard and other pages.
Initially thought it was due to my call load where I have more than 120K calls per day with 4.45 min median call time
I did the needful on mysql db optimization and was having 99% table open cache efficiency and 91% innodb buffer pool usage.
Then did a mysql client connections checkup and did an analysis while traversing through the pages
Found that common_model.php near line 205 → $data_array[‘no_of_calls’] = $this->db_model->getSelect('(ROUND(sum(billseconds) / 60.0, 0) * 60) query popping up on all web-page client connections.
It was taking more than 8s to execute so the pages
7.Then I disabled calling on get_dashboard_details() on line number 35 and tested.
Issues solved.

Now tell me how the hell I am raising a PR without knowing the actual use of the function ? I was just providing some of my findings just to help Original owner of the code and community.

Being effective for my problem does not means it is correct and PR worthy isn’t it ?

KNERD · July 16, 2023, 8:02pm

Maybe you should try this fix as reported by @sman123

linux.kernel · July 18, 2023, 1:07pm

But this is different. Common_Model is being called by the CI Auto-loader it seems.

linux.kernel · July 18, 2023, 1:08pm

@devangn can check on this pls ?

KNERD · July 18, 2023, 6:38pm

By your response, I take it you did not read all of that thread in the link I sent you to.